Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset

From: Chris Packham
Date: Wed Sep 02 2020 - 16:58:14 EST



On 2/09/20 8:45 pm, Andy Shevchenko wrote:
> On Wed, Sep 02, 2020 at 11:43:56AM +0300, Andy Shevchenko wrote:
>> On Wed, Sep 02, 2020 at 09:17:47AM +1200, Evan Nimmo wrote:
>>> If something goes wrong (such as the SCL being stuck low) then we need
>>> to reset the PCA chip. The issue with this is that on reset we lose all
>>> config settings and the chip ends up in a disabled state which results
>>> in a lock up/high cpu usage. We need to re-apply any configuration that
>> cpu -> CPU (I guess Wolfram can decide with this when applying)
>>
>>> had previously been set and re-enable the chip.
>> FWIW,
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> And actually you forgot Chris' tag... But I dunno if the moving struct
> definition is something that Chris might not like.
>
Fine by me.

Reviewed-by: Chris Packham <chris.packham@xxxxxxxxxxxxxxxxxxx>