Re: [PATCH v1 03/12] i2c: tegra: Clean up messages in the code
From: Dmitry Osipenko
Date: Wed Sep 02 2020 - 17:17:06 EST
02.09.2020 23:42, Michał Mirosław пишет:
> On Mon, Aug 31, 2020 at 11:22:54PM +0300, Dmitry Osipenko wrote:
>> Use lowercase and consistent wording for all messages in the code.
>>
>> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx>
>> ---
>> drivers/i2c/busses/i2c-tegra.c | 50 ++++++++++++++++------------------
>> 1 file changed, 24 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
>> index 9bd91b6f32f4..efbb20049cf8 100644
>> --- a/drivers/i2c/busses/i2c-tegra.c
>> +++ b/drivers/i2c/busses/i2c-tegra.c
>> @@ -427,7 +427,7 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
>> return 0;
>>
>> if (!IS_ENABLED(CONFIG_TEGRA20_APB_DMA)) {
>> - dev_dbg(i2c_dev->dev, "Support for APB DMA not enabled!\n");
>> + dev_dbg(i2c_dev->dev, "dma support not enabled\n");
>> return 0;
> [...]
>
> DMA is an acronym and so I would usually write it in uppercase for grammatical
> correctness unless in a function's name.
Andy Shevchenko suggested the same thing in other reply, I'll change it
in v3. Thanks!