Re: [PATCH v2 3/9] iommu/ioasid: Introduce ioasid_set APIs

[Jacob Pan]

On Mon, 24 Aug 2020 11:30:47 -0700
Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> On 8/24/20 11:28 AM, Jean-Philippe Brucker wrote:
> >> +/**
> >> + * struct ioasid_data - Meta data about ioasid
> >> + *
> >> + * @id:		Unique ID
> >> + * @users	Number of active users
> >> + * @state	Track state of the IOASID
> >> + * @set		Meta data of the set this IOASID belongs to
> >> + * @private	Private data associated with the IOASID
> >> + * @rcu		For free after RCU grace period  
> > nit: it would be nicer to follow the struct order  
> 
> and use a ':' after each struct member name, as is done for @id:
> 
Got it, thanks.