Re: [RESEND PATCH v14 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors

[Andy Shevchenko]

On Thu, Sep 3, 2020 at 1:43 PM Shiju Jose <shiju.jose@xxxxxxxxxx> wrote:
> >From: Andy Shevchenko [mailto:andriy.shevchenko@xxxxxxxxxxxxxxx]
> >Sent: 01 September 2020 09:26
> >On Mon, Aug 31, 2020 at 10:26:06PM +0100, Shiju Jose wrote:
> >> From: Yicong Yang <yangyicong@xxxxxxxxxxxxx>

...

> >> +config PCIE_HISI_ERR
> >> +    depends on ACPI_APEI_GHES && (ARM64 || COMPILE_TEST)
> >
> >> +    depends on ACPI
> >
> >Isn't this implied by
> >       drivers/acpi/Kconfig:45:if ACPI
> >?
>
> This can be removed as  ACPI_APEI_GHES depends on ACPI.
>
> Do you have any other comments on this patch?

Nope. The rest is fine to me.

> >> +    bool "HiSilicon HIP PCIe controller error handling driver"
> >> +    help
> >> +      Say Y here if you want error handling support
> >> +      for the PCIe controller's errors on HiSilicon HIP SoCs

-- 
With Best Regards,
Andy Shevchenko