Re: [PATCH v9 3/3] mm/madvise: introduce process_madvise() syscall: an external memory hinting API

From: Minchan Kim
Date: Thu Sep 03 2020 - 13:59:58 EST


On Thu, Sep 03, 2020 at 07:34:58PM +0200, Florian Weimer wrote:
> * Minchan Kim:
>
> > On Tue, Sep 01, 2020 at 08:46:02PM +0200, Florian Weimer wrote:
> >> * Minchan Kim:
> >>
> >> > ssize_t process_madvise(int pidfd, const struct iovec *iovec,
> >> > unsigned long vlen, int advice, unsigned int flags);
> >>
> >> size_t for vlen provides a clearer hint regarding the type of special
> >> treatment needed for ILP32 here (zero extension, not changing the type
> >> to long long).
> >>
> >
> > All existing system calls using iove in Linux uses unsigned long so
> > I want to be consistent with them unless process_madvise need something
> > speicial.
>
> Userspace uses int, following POSIX (where applicable). There is no
> consistency to be had here.

Okay, I changed it with size_t.