[PATCH] EDAC/mc_sysfs: add missing newlines when printing 'max(dimm)_location'
From: Xiongfeng Wang
Date: Fri Sep 04 2020 - 04:27:00 EST
When I cat 'max_location' and 'dimm_location' by sysfs, it displays as
follows. It's better to add a newline for easy reading.
[root@localhost /]# cat /sys/devices/system/edac/mc/mc0/max_location
memory 3 [root@localhost /]# cat /sys/devices/system/edac/mc/mc0/dimm0/dimm_location
memory 0 [root@localhost /]#
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@xxxxxxxxxx>
---
I am not sure if there are some userspace tools using this file.
---
drivers/edac/edac_mc_sysfs.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c
index 4e6aca5..5d7b079 100644
--- a/drivers/edac/edac_mc_sysfs.c
+++ b/drivers/edac/edac_mc_sysfs.c
@@ -474,8 +474,12 @@ static ssize_t dimmdev_location_show(struct device *dev,
struct device_attribute *mattr, char *data)
{
struct dimm_info *dimm = to_dimm(dev);
+ ssize_t count;
- return edac_dimm_info_location(dimm, data, PAGE_SIZE);
+ count = edac_dimm_info_location(dimm, data, PAGE_SIZE);
+ count += snprintf(data + count, PAGE_SIZE - count, "\n");
+
+ return count;
}
static ssize_t dimmdev_label_show(struct device *dev,
@@ -821,6 +825,7 @@ static ssize_t mci_max_location_show(struct device *dev,
edac_layer_name[mci->layers[i].type],
mci->layers[i].size - 1);
}
+ p += sprintf(p, "\n");
return p - data;
}
--
1.7.12.4