Re: [PATCH v5] iommu/mediatek: check 4GB mode by reading infracfg

[Miles Chen]

On Fri, 2020-09-04 at 11:42 +0200, Joerg Roedel wrote:
> On Mon, Aug 31, 2020 at 06:56:39PM +0800, Miles Chen wrote:
> > In previous discussion [1] and [2], we found that it is risky to
> > use max_pfn or totalram_pages to tell if 4GB mode is enabled.
> > 
> > Check 4GB mode by reading infracfg register, remove the usage
> > of the un-exported symbol max_pfn.
> > 
> > This is a step towards building mtk_iommu as a kernel module.
> > 
> > [1] https://lore.kernel.org/lkml/20200603161132.2441-1-miles.chen@xxxxxxxxxxxx/
> > [2] https://lore.kernel.org/lkml/20200604080120.2628-1-miles.chen@xxxxxxxxxxxx/
> > [3] https://lore.kernel.org/lkml/20200715205120.GA778876@bogus/
> > 
> > Cc: Mike Rapoport <rppt@xxxxxxxxxxxxx>
> > Cc: David Hildenbrand <david@xxxxxxxxxx>
> > Cc: Yong Wu <yong.wu@xxxxxxxxxxxx>
> > Cc: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> > Cc: Christoph Hellwig <hch@xxxxxx>
> > Cc: Rob Herring <robh@xxxxxxxxxx>
> > Cc: Matthias Brugger <matthias.bgg@xxxxxxxxx>
> > Signed-off-by: Miles Chen <miles.chen@xxxxxxxxxxxx>
> 
> You forgot to add the tags here from v4, at least Matthias' Reviewed-by
> is missing. Please add the missing tags and resend.

Thanks for reminding. I'll add the tag and resend this patch ASAP.

Miles
> 
> 
> 	Joerg