Re: [PATCH v3 5/7] dt-bindings: arm: rockchip: Add Engicam PX30.Core C.TOUCH 2.0

From: Rob Herring
Date: Fri Sep 04 2020 - 10:50:57 EST


On Thu, Sep 3, 2020 at 10:47 AM Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Thu, Sep 3, 2020 at 9:55 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Mon, 31 Aug 2020 13:59:15 +0530, Jagan Teki wrote:
> > > PX30.Core is an EDIMM SOM based on Rockchip PX30 from Engicam.
> > >
> > > C.TOUCH 2.0 is a general purpose carrier board with capacitive
> > > touch interface support.
> > >
> > > PX30.Core needs to mount on top of this Carrier board for creating
> > > complete PX30.Core C.TOUCH 2.0 board.
> > >
> > > Add bindings for it.
> > >
> > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx>
> > > ---
> > > Changes for v3:
> > > - none
> > > Changes for v2:
> > > - new patch
> > >
> > > Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> >
> >
> > Please add Acked-by/Reviewed-by tags when posting new versions. However,
> > there's no need to repost patches *only* to add the tags. The upstream
> > maintainer will do that for acks received on the version they apply.
> >
> > If a tag was not added on purpose, please state why and what changed.
>
> Yes, it's on purpose. The previous binding was about C.TOUCH with LVDS
> board and this one is C.TOUCH carrier only. ie the main reason I have
> not included. I did mention in the cover-letter saying previous one
> dropped and the C.TOUCH carrier added.

The changelog here says no changes...

Anyways,

Acked-by: Rob Herring <robh@xxxxxxxxxx>