Re: [PATCH] perf metric: Fix some memory leaks

[Arnaldo Carvalho de Melo]

Em Fri, Sep 04, 2020 at 10:39:50PM +0900, Namhyung Kim escreveu:
> On Fri, Sep 4, 2020 at 1:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > On Thu, Sep 3, 2020 at 8:21 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> > >
> > > I found some memory leaks while reading the metric code.  Some are
> > > real and others only occur in the error path.
> >
> > Thanks Namhyung! Is it possible to get test coverage?
> > Ian
> 
> Not sure what you want..
> 
> As I found it from code inspection I don't know if there's a test covering this.
> 
> But as far as I can see, 2 of them are on the error path so maybe not easy
> to add a test, other one is called from perf list code, and the last one is on
> the normal code path so any test should cover it.

Humm, I assume all those fixes were for csets in a single Linux version,
right? Otherwise I think it'd be better to have a fix per Fixes tag, so
that they would go to the kernel sources where those bugs were fixed.

Thanks!

- Arnaldo