Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)

[Konrad Dybcio]

> Thank you for the pointer. I dug around the vph_pwr fixed-regulator
> node used by fellow sdm845 devices. I assume it is safe to copy it
> from sdm845-mtp but I couldn't verify it in the downstream
> device-tree, so I'm a bit hesitant. My main concern is that I don't
> want to burn down my only device :)

Sure, nobody does ^^

> I did find a few regulator nodes downstream which matches with
> upstream sdm845-mtp but since I'm not using any of them in my
> beryllium dts, I'm going to skip them for now.

Looking at their DTSes, Xiaomi doesn't seem to stray far away from MTP designs.

> As you pointed out, in case of regulator lookup failure Linux will
> fall back to dummy regulators, which is working fine for me so far.
> Also I see that vdd-*-supply properties are optional according to
> Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt,
> so I assume it is safe to skip them?

Yes, but keep in mind it would be a good idea to add them later, after
you're sure everything's okay :)


P.S. My current daily driver is Xiaomi Mi 8, which is basically Poco
with an OLED and glass back (among some other minor nicer things), so
thanks for your work, I might benefit from it in the future :)

Konrad