Re: [PATCH] /dev/zero: also implement ->read

[Pavel Machek]

Hi!

> > > Christophe reported a major speedup due to avoiding the iov_iter
> > > overhead, so just add this trivial function.  Note that /dev/zero
> > > already implements both an iter and non-iter writes so this just
> > > makes it more symmetric.
> > >
> > > Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> > > Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> > 
> > Tested-by: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
> 
> Any idea what has happened to make the 'iter' version so bad?

Exactly. Also it would be nice to note how the speedup was measured
and what the speedup is.

Best regads,
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature