Re: [PATCH v2 05/12] phy: tegra: xusb: add sleepwalk and suspend/resume

[JC Kuo]

Hi Thierry,
Thanks for review. I will amend accordingly and submit a new patch.

JC

On 8/31/20 7:58 PM, Thierry Reding wrote:
> Again, use a capital letter to start the subject after the prefix.
> 
> On Mon, Aug 31, 2020 at 12:40:36PM +0800, JC Kuo wrote:
>> This commit adds sleepwalk/wake and suspend/resume interfaces
>> to Tegra XUSB PHY driver.
>>
>> Tegra XUSB host controller driver makes use of sleepwalk functions
>> to enable/disable sleepwalk circuit which is in always-on partition
>> can respond to USB resume signals when controller is not powered.
> 
> "and can respond to ..."?
> 
>> Sleepwalk can be enabled/disabled for any USB phy individually.
> 
> "USB PHY"
> 
>>
>>   - tegra_xusb_padctl_enable_phy_sleepwalk()
>>   - tegra_xusb_padctl_disable_phy_sleepwalk()
>>
>> Tegra XUSB host controller driver makes use of wake functions to
>> enable/disable/query wake circuit which is in always-on partition
>> can wake system up when USB resume happens.
>> Wake circuit can be enabled/disabled for any USB phy individually.
> 
> "USB PHY"
> 
> Thierry
>