Re: [PATCH] firmware: ti_sci: allow frequency change for disabled clocks by default

[Nishanth Menon]

On 14:03-20200907, Tero Kristo wrote:
> If a clock is disabled, its frequency should be allowed to change as
> it is no longer in use. Add a flag towards this to the firmware clock
> API handler routines.
> 
> Tested-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx>
> Signed-off-by: Tero Kristo <t-kristo@xxxxxx>
> ---
>  drivers/firmware/ti_sci.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index 53cee17d0115..39890665a975 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -1124,7 +1124,8 @@ static int ti_sci_cmd_get_clock(const struct ti_sci_handle *handle, u32 dev_id,
>  static int ti_sci_cmd_idle_clock(const struct ti_sci_handle *handle,
>  				 u32 dev_id, u32 clk_id)
>  {
> -	return ti_sci_set_clock_state(handle, dev_id, clk_id, 0,
> +	return ti_sci_set_clock_state(handle, dev_id, clk_id,
> +				      MSG_FLAG_CLOCK_ALLOW_FREQ_CHANGE,
>  				      MSG_CLOCK_SW_STATE_UNREQ);
>  }
>  
> @@ -1143,7 +1144,8 @@ static int ti_sci_cmd_idle_clock(const struct ti_sci_handle *handle,
>  static int ti_sci_cmd_put_clock(const struct ti_sci_handle *handle,
>  				u32 dev_id, u32 clk_id)
>  {
> -	return ti_sci_set_clock_state(handle, dev_id, clk_id, 0,
> +	return ti_sci_set_clock_state(handle, dev_id, clk_id,
> +				      MSG_FLAG_CLOCK_ALLOW_FREQ_CHANGE,
>  				      MSG_CLOCK_SW_STATE_AUTO);
>  }
>  

Acked-by: Nishanth Menon <nm@xxxxxx>

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D