RE: [PATCH net-next] net: xilinx: remove redundant null check before clk_disable_unprepare()

[Radhey Shyam Pandey]

> -----Original Message-----
> From: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
> Sent: Monday, September 7, 2020 6:32 PM
> To: Radhey Shyam Pandey <radheys@xxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> kuba@xxxxxxxxxx; Michal Simek <michals@xxxxxxxxxx>
> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: [PATCH net-next] net: xilinx: remove redundant null check before
> clk_disable_unprepare()
> 
> Because clk_prepare_enable() and clk_disable_unprepare() already checked
> NULL clock parameter, so the additional checks are unnecessary, just
> remove them.
> 
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>

Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>

Thanks!
> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index fa5dc299..9aafd3e 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2038,8 +2038,7 @@ static int axienet_remove(struct platform_device
> *pdev)
> 
>  	axienet_mdio_teardown(lp);
> 
> -	if (lp->clk)
> -		clk_disable_unprepare(lp->clk);
> +	clk_disable_unprepare(lp->clk);
> 
>  	of_node_put(lp->phy_node);
>  	lp->phy_node = NULL;
> --
> 2.9.5