Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only

From: Borislav Petkov
Date: Mon Sep 07 2020 - 16:27:51 EST


On Mon, Sep 07, 2020 at 01:16:43PM -0700, Andy Lutomirski wrote:
> > + asm volatile("rdmsr" : EAX_EDX_RET(val, low, high) : "c" (msr));
>
> I don't like this. Plain rdmsrl() will at least print a nice error if it fails.

I think you read my commit message too quickly :)

The point is to not print anything and not have *any* exception handling
or whatever - just plain RDMSR.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette