Re: [PATCH v2 10/11] dwc3-of-simple: add support for Hikey 970

[Mauro Carvalho Chehab]

Em Mon,  7 Sep 2020 17:59:34 +0200
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> escreveu:

> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 8852fbfdead4..2d497165efe2 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
>  	 * Some controllers need to toggle the usb3-otg reset before trying to
>  	 * initialize the PHY, otherwise the PHY times out.
>  	 */
> -	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))
> +	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
> +	    of_device_is_compatible(np, "hisilicon,hi3670-dwc3"))
>  		simple->need_reset = true;

It turns that this hunk caused Serror during my suspend/resume tests.

Without this one, the driver works just fine.

As you already applied this patch, do you prefer a patch dropping it,
or should I send a version 2 without it?

Thanks,
Mauro