RE: [PATCH v8 1/3] phy: intel: Rename phy-intel to phy-intel-lgm

From: Wan Mohamad, Wan Ahmad Zainie
Date: Tue Sep 08 2020 - 04:47:41 EST




> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: Tuesday, September 1, 2020 4:11 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
> Cc: kishon@xxxxxx; vkoul@xxxxxxxxxx; robh+dt@xxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx;
> eswara.kota@xxxxxxxxxxxxxxx; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@xxxxxxxxx>
> Subject: Re: [PATCH v8 1/3] phy: intel: Rename phy-intel to phy-intel-lgm
>
> On Tue, Sep 01, 2020 at 12:41:59PM +0800, Wan Ahmad Zainie wrote:
> > Rename phy-intel-{combo,emmc}.c to phy-intel-lgm-{combo,emmc}.c to
> > make drivers/phy/intel directory more generic for future use.
> >
> > Signed-off-by: Wan Ahmad Zainie
> > <wan.ahmad.zainie.wan.mohamad@xxxxxxxxx>
>
> > Reviewed-by: Ramuthevar Vadivel Murugan
> > <vadivel.muruganx.ramuthevar@xxxxxxxxxxxxxxx>
>
> This shall be one line.

I will fix this in v9.

>
> > ---
> > drivers/phy/intel/Kconfig | 10 +++++-----
> > drivers/phy/intel/Makefile | 4 ++--
> > .../intel/{phy-intel-combo.c => phy-intel-lgm-combo.c} | 0
> > .../intel/{phy-intel-emmc.c => phy-intel-lgm-emmc.c} | 0
> > 4 files changed, 7 insertions(+), 7 deletions(-) rename
> > drivers/phy/intel/{phy-intel-combo.c => phy-intel-lgm-combo.c} (100%)
> > rename drivers/phy/intel/{phy-intel-emmc.c => phy-intel-lgm-emmc.c}
> > (100%)
> >
> > diff --git a/drivers/phy/intel/Kconfig b/drivers/phy/intel/Kconfig
> > index 7b47682a4e0e..db8586c3eed8 100644
> > --- a/drivers/phy/intel/Kconfig
> > +++ b/drivers/phy/intel/Kconfig
> > @@ -1,9 +1,9 @@
> > # SPDX-License-Identifier: GPL-2.0
> > #
> > -# Phy drivers for Intel Lightning Mountain(LGM) platform
> > +# Phy drivers for Intel platforms
> > #
> > -config PHY_INTEL_COMBO
> > - bool "Intel ComboPHY driver"
> > +config PHY_INTEL_LGM_COMBO
> > + bool "Intel Lightning Mountain ComboPHY driver"
> > depends on X86 || COMPILE_TEST
> > depends on OF && HAS_IOMEM
> > select MFD_SYSCON
> > @@ -16,8 +16,8 @@ config PHY_INTEL_COMBO
> > chipsets which provides PHYs for various controllers, EMAC,
> > SATA and PCIe.
> >
> > -config PHY_INTEL_EMMC
> > - tristate "Intel EMMC PHY driver"
> > +config PHY_INTEL_LGM_EMMC
> > + tristate "Intel Lightning Mountain EMMC PHY driver"
> > depends on X86 || COMPILE_TEST
> > select GENERIC_PHY
> > help
> > diff --git a/drivers/phy/intel/Makefile b/drivers/phy/intel/Makefile
> > index 233d530dadde..662385d0a366 100644
> > --- a/drivers/phy/intel/Makefile
> > +++ b/drivers/phy/intel/Makefile
> > @@ -1,3 +1,3 @@
> > # SPDX-License-Identifier: GPL-2.0
> > -obj-$(CONFIG_PHY_INTEL_COMBO) += phy-intel-combo.o
> > -obj-$(CONFIG_PHY_INTEL_EMMC) += phy-intel-emmc.o
> > +obj-$(CONFIG_PHY_INTEL_LGM_COMBO) += phy-intel-lgm-combo.o
> > +obj-$(CONFIG_PHY_INTEL_LGM_EMMC) += phy-intel-lgm-emmc.o
> > diff --git a/drivers/phy/intel/phy-intel-combo.c
> > b/drivers/phy/intel/phy-intel-lgm-combo.c
> > similarity index 100%
> > rename from drivers/phy/intel/phy-intel-combo.c
> > rename to drivers/phy/intel/phy-intel-lgm-combo.c
> > diff --git a/drivers/phy/intel/phy-intel-emmc.c
> > b/drivers/phy/intel/phy-intel-lgm-emmc.c
> > similarity index 100%
> > rename from drivers/phy/intel/phy-intel-emmc.c
> > rename to drivers/phy/intel/phy-intel-lgm-emmc.c
> > --
> > 2.17.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>