Re: [RFC PATCH] x86/mce: Make mce_rdmsrl() do a plain RDMSR only

From: Borislav Petkov
Date: Tue Sep 08 2020 - 06:08:42 EST


On Tue, Sep 08, 2020 at 11:46:50AM +0200, Borislav Petkov wrote:
> So, Andy suggested we do a simple .fixup so that when the RDMSR fails,
> in the fixup we panic directly.

Ok, so I think this is what Andy meant last night and PeterZ just
suggested it too:

We do a:

_ASM_EXTABLE_HANDLE(1b, 2b, ex_handler_panic)

which panics straight in the #GP handler and avoids the IRET.

I mean, we want to panic there because architectural violation and we
won't have to deal with the IRET...

Hohumm, sounds like the right thing to do in the face of the brokenness
of this magnificent architecture.</maxed out sarcasm>.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette