Re: [PATCH v10 02/16] s390/vfio-ap: use new AP bus interface to search for queue devices

From: Tony Krowiak
Date: Tue Sep 08 2020 - 14:56:22 EST

On 9/4/20 4:11 AM, Christian Borntraeger wrote:

On 21.08.20 21:56, Tony Krowiak wrote:
This patch refactor's the vfio_ap device driver to use the AP bus's
ap_get_qdev() function to retrieve the vfio_ap_queue struct containing
information about a queue that is bound to the vfio_ap device driver.
The bus's ap_get_qdev() function retrieves the queue device from a
hashtable keyed by APQN. This is much more efficient than looping over
the list of devices attached to the AP bus by several orders of

Signed-off-by: Tony Krowiak <akrowiak@xxxxxxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
I think this can go. No need to mark that an earlier version of this patch had an issue.

I was just following the instructions in the robot comments. I'll get rid of it.


diff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h
index f46dde56b464..a2aa05bec718 100644
--- a/drivers/s390/crypto/vfio_ap_private.h
+++ b/drivers/s390/crypto/vfio_ap_private.h
@@ -18,6 +18,7 @@
#include <linux/delay.h>
#include <linux/mutex.h>
#include <linux/kvm_host.h>
+#include <linux/hashtable.h>
I dont think that this header file needs it. Any user of it will now include this.
Can you move this include into the respective C file when the hash stuff is

I can.

Other than that this looks good.