Re: [PATCH 4/5] drm/panfrost: add amlogic reset quirk callback

From: Alyssa Rosenzweig
Date: Tue Sep 08 2020 - 15:10:41 EST

> Since the documentation of the GPU cores are not public, we do not know what does these
> values, but they permit having a fully functional GPU running with Panfrost.

Since this is Amlogic magic, not specifically GPU, I'd rephrase this as
"Since the Amlogic's integration of the GPU cores with the SoC is not
publicly documented..."

> + /*
> + * The Amlogic integrated Mali-T820, Mali-G31 & Mali-G52 needs
> + * these undocumented bits to be set in order to operate
> + * correctly.
> + * These GPU_PWR registers contains:
> + * "device-specific power control value"
> + */

PWR_OVERRIDE1 is the Amlogic specific value.

Per the name, for PWR_KEY, I'd do add "#define GPU_PWR_KEY_UNLOCK
0x2968A819" in panfrost-gpu.h so it's clear which value is which.

Attachment: signature.asc
Description: PGP signature