Re: [PATCH v1] driver core: Annotate dev_err_probe() with __must_check

From: Krzysztof Kozlowski
Date: Wed Sep 09 2020 - 02:29:44 EST


On Wed, 26 Aug 2020 at 18:18, Joe Perches <joe@xxxxxxxxxxx> wrote:
>
> On Wed, 2020-08-26 at 18:55 +0300, Andy Shevchenko wrote:
> > On Wed, Aug 26, 2020 at 08:44:30AM -0700, Joe Perches wrote:
> > > On Wed, 2020-08-26 at 13:44 +0300, Andy Shevchenko wrote:
> >
> > ...
> >
> > > > -int dev_err_probe(const struct device *dev, int err, const char *fmt, ...);
> > > > +int __must_check dev_err_probe(const struct device *dev, int err, const char *fmt, ...);

+Cc Stephen and Greg,

Hi Andy,

Did this patch ended up in next somehow? I am surprised because now I
got warnings for perfectly fine code:
https://lore.kernel.org/linux-next/20200909155654.76fe3bd6@xxxxxxxxxxxxxxxx/T/#u

This creates simply false warnings instead of hints for "optimization".

Best regards,
Krzysztof