Re: [PATCH v2] HID: google: add google vivaldi HID driver

From: Jiri Kosina
Date: Wed Sep 09 2020 - 02:36:43 EST

On Wed, 26 Aug 2020, Sean O'Brien wrote:

> > I actually believe we should follow the standard convention here, and have
> > just one hid-<vendor> driver for all google products. Currently we have
> > hid-google-hammer, and this would add hid-google-vivaldi. Would you (or
> > Wei-Ning, CCing here) object on merging these two together?
> I'm a bit reluctant to merge them. Partly because I'm not familiar with
> the hid-google-hammer driver, but mostly because this driver is intended
> to handle non-google products which will use a google-defined usage code.
> Perhaps I should drop "google" from the driver name?

If it's known that it will be handling non-google products, then I think
that's indeed the best option. Thanks in advance for v3 with this change,

Jiri Kosina