Re: [PATCH v3 0/3] ASoC: Add sdw stream operations to dailink ops.

From: Vinod Koul
Date: Wed Sep 09 2020 - 03:49:33 EST


On 08-09-20, 14:26, Jaroslav Kysela wrote:
> Dne 04. 09. 20 v 20:28 Bard Liao napsal(a):
> > Sdw stream operation APIs can be called once per stream. Move these
> > operations to dailink ops. The linked series is "soundwire: Remove sdw
> > stream operations from Intel soundwire dai".
> >
> > Reviewed-by: Vinod Koul <vkoul@xxxxxxxxxx>
> >
> > Changes in v3:
> > - s/ASOC/ASoC
> >
> > Pierre-Louis Bossart (3):
> > ASoC: soc-dai: clarify return value for get_sdw_stream()
> > ASoC: Intel: sof_sdw: add dailink .trigger callback
> > ASoC: Intel: sof_sdw: add dailink .prepare and .hw_free callback
> >
> > include/sound/soc-dai.h | 3 +-
> > sound/soc/intel/boards/sof_sdw.c | 81 ++++++++++++++++++++++++++++++++
> > 2 files changed, 83 insertions(+), 1 deletion(-)
> >
>
> This patchset depends on the SoundWire patchset
> "[PATCH v2 0/4] soundwire: Remove sdw stream operations from Intel" and
> cannot be used standalone. I believe that one maintainer should accept it or
> there should be a co-ordination between Mark and Vinod to push this in sync.
> We should really settle, how to accept such changes. I believe that Vinod
> should take it with the ack from Mark for this case. Please, don't require to
> split changes which depends on each other.

I did ask about dependencies, and IIRC looking at code there were none.
Yes you need both the parts to make it work, but both the trees build
fine and these will go for 5.10, so I think these merged are okay.

>
> For all above patches (I tested them):
>
> Acked-by: Jaroslav Kysela <perex@xxxxxxxx>
>
> --
> Jaroslav Kysela <perex@xxxxxxxx>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

--
~Vinod