Re: [PATCH: V2 1/2] gpio: tc35894: fix up tc35894 interrupt configuration

From: Bartosz Golaszewski
Date: Wed Sep 09 2020 - 05:34:46 EST


On Thu, Sep 3, 2020 at 9:30 AM <dillon.minfei@xxxxxxxxx> wrote:
>
> From: dillon min <dillon.minfei@xxxxxxxxx>
>
> The offset of regmap is incorrect, j * 8 is move to the
> wrong register.
>
> for example:
>
> asume i = 0, j = 1. we want to set KPY5 as interrupt
> falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd
> but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4,
> this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1.
>
> Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver")
> Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>
> ---
>

Queued for fixes.

Thanks!
Bartosz