Re: [PATCH v2] gpio: siox: explicitly support only threaded irqs

[Uwe Kleine-König]

On Wed, Sep 09, 2020 at 11:43:24AM +0200, Bartosz Golaszewski wrote:
> On Mon, Sep 7, 2020 at 5:32 PM Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx> wrote:
> >
> > The gpio-siox driver uses handle_nested_irq() to implement its
> > interrupt support. This is only capable of handling threaded irq
> > actions. For a hardirq action it triggers a NULL pointer oops.
> > (It calls action->thread_fn which is NULL then.)
> >
> > Prevent registration of a hardirq action by setting
> > gpio_irq_chip::threaded to true.
> >
> > Cc: u.kleine-koenig@xxxxxxxxxxxxxx
> > Signed-off-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> > ---
> 
> Could you add a Fixes tag? This looks like stable material.

Ah, we talked about this in the v1 thread---tglx and I agreed we want
it. That's:

Fixes: be8c8facc707 ("gpio: new driver to work with a 8x12 siox")

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Attachment: signature.asc
Description: PGP signature