Re: [PATCH V4 1/4] arm64: dts: sc7180: Add wakeup support over UART RX

From: skakit
Date: Wed Sep 09 2020 - 13:08:49 EST

On 2020-09-03 22:47, Matthias Kaehlcke wrote:
On Thu, Sep 03, 2020 at 08:34:55PM +0530, satya priya wrote:
Add the necessary pinctrl and interrupts to make UART wakeup capable.

If QUP function is selected in sleep state, UART RTS/RFR is pulled high
during suspend and BT SoC not able to send wakeup bytes. So, configure
GPIO mode in sleep state to keep it low during suspend.

Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
Reviewed-by: Akash Asthana <akashast@xxxxxxxxxxxxxx>

One more doubt: does it actually make sense/is it safe to add the
sleep config for all UARTs in the SoC file?

yes, it is not good to have it this way. We are going to remove all this and add sleep config for only uart3 (BT uart) in board specific file.

I wonder if there could
be undesired behavior (like noise on TX or RTS looking active to the
other side) without the corresponding pinconf in the board file. If
the pinconf is needed to avoid unexpected behavior then it is better
to change the muxing in the board file to have a sane default
configuration in the SoC .dtsi.

ok, will add pinmux for uart3 sleep state in board file.

From a quick grep it seems that most SoCs don't specify a sleep config
for their UART pins and some boards add it in their DT.