Re: [MPTCP][PATCH v2 net 1/2] mptcp: fix subflow's local_id issues

From: Matthieu Baerts
Date: Wed Sep 09 2020 - 13:14:34 EST

Hi Geliang,

On 08/09/2020 04:49, Geliang Tang wrote:
In mptcp_pm_nl_get_local_id, skc_local is the same as msk_local, so it
always return 0. Thus every subflow's local_id is 0. It's incorrect.

This patch fixed this issue.

Also, we need to ignore the zero address here, like in IPv4. When
we use the zero address as a local address, it means that we can use any
one of the local addresses. The zero address is not a new address, we don't
need to add it to PM, so this patch added a new function address_zero to
check whether an address is the zero address, if it is, we ignore this

Fixes: 01cacb00b35cb ("mptcp: add netlink-based PM")
Signed-off-by: Geliang Tang <geliangtang@xxxxxxxxx>

Thank you for the v2!

Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>

Tessares | Belgium | Hybrid Access Solutions