Re: [PATCH v2] mm/vmscan: fix infinite loop in drop_slab_node

From: Chris Down
Date: Wed Sep 09 2020 - 17:47:32 EST


Vlastimil Babka writes:
- Exit also on other signals such as SIGABRT, SIGTERM? If I write to drop_caches
and think it's too long, I would prefer to kill it by ctrl-c and not just kill

Oh dear, fatal_signal_pending() doesn't consider cases with no more userspace instructions due to SIG_DFL on TERM/INT etc, that seems misleading :-( I had (naively) believed it internally checks the same set as TASK_KILLABLE.

Chuxin, Muchun, can you please make it work using TASK_KILLABLE in a similar way to how schedule_timeout_killable and friends do it instead, so that other signals will be caught?