Re: [PATCH] ide/macide: Convert Mac IDE driver to platform driver

[Michael Schmitz]

Hi Finn,

Am 10.09.2020 um 12:23 schrieb Finn Thain:
> > > +       return 0;
> > > +
> > > +release_mem:
> > > +       release_mem_region(mem->start, resource_size(mem));
> >
> > Not needed, as you used devm_*() for allocation.
>
> OK, I'll remove this. I put it there after I looked at falconide.c and
> wondered whether the automatic release would take place after both init
> failure and exit (or just exit). I see now that pata_gayle.c does it
> differently.

pata_gayle.c has probably seen more testing (in the platform 
environment), so I'd go with what's done there.

Cheers,

	Michael