Re: [PATCH v4 2/3] media: uapi: Add VP9 stateless decoder controls

[Alexandre Courbot]

On Thu, Sep 10, 2020 at 3:04 PM Alexandre Courbot <acourbot@xxxxxxxxxxxx> wrote:
>
> Hi Ezequiel, sorry for the late review!
>
> On Tue, May 19, 2020 at 2:40 AM Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> wrote:
> >
> > From: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> >
> > Add the VP9 stateless decoder controls plus the documentation that goes
> > with it.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@xxxxxxxxxxxxx>
> > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> > ---
> >  .../userspace-api/media/v4l/biblio.rst        |  10 +
> >  .../media/v4l/ext-ctrls-codec.rst             | 550 ++++++++++++++++++
> >  drivers/media/v4l2-core/v4l2-ctrls.c          | 239 ++++++++
> >  drivers/media/v4l2-core/v4l2-ioctl.c          |   1 +
> >  include/media/v4l2-ctrls.h                    |   1 +
> >  include/media/vp9-ctrls.h                     | 485 +++++++++++++++

Also another thing I missed: shouldn't the new pointer controls be
added to union v4l2_ctrl_ptr in v4l2-ctrls.h?