Re: [PATCH 3/4] kbuild: remove cc-option test of -fno-stack-check

[Nathan Chancellor]

On Thu, Sep 10, 2020 at 10:51:19PM +0900, Masahiro Yamada wrote:
> The minimal compiler versions, GCC 4.9 and Clang 10 support this flag.
> 
> Here is the godbolt:
> https://godbolt.org/z/59cK6o
> 
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>

This flag is technically ignored by clang (see commit
05b0798916f01690b5903302e51f3136274e291f) but that obviously does not
matter for the sake of this.

Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>

> ---
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 1b6abecc5cab..5102c89d3167 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -934,7 +934,7 @@ KBUILD_CFLAGS	+= -fno-merge-all-constants
>  KBUILD_CFLAGS	+= $(call cc-option,-fmerge-constants)
>  
>  # Make sure -fstack-check isn't enabled (like gentoo apparently did)
> -KBUILD_CFLAGS  += $(call cc-option,-fno-stack-check,)
> +KBUILD_CFLAGS  += -fno-stack-check
>  
>  # conserve stack if available
>  KBUILD_CFLAGS   += $(call cc-option,-fconserve-stack)
> -- 
> 2.25.1
>