Re: [PATCH net] net: dec: de2104x: Increase receive ring size for Tulip

[Moritz Fischer]

On Thu, Sep 10, 2020 at 12:05:09PM -0700, Lucy Yan wrote:
> Increase Rx ring size to address issue where hardware is reaching
> the receive work limit.
> 
> Before:
> 
> [  102.223342] de2104x 0000:17:00.0 eth0: rx work limit reached
> [  102.245695] de2104x 0000:17:00.0 eth0: rx work limit reached
> [  102.251387] de2104x 0000:17:00.0 eth0: rx work limit reached
> [  102.267444] de2104x 0000:17:00.0 eth0: rx work limit reached
> 
> Signed-off-by: Lucy Yan <lucyyan@xxxxxxxxxx>
Reviewed-by: Moritz Fischer <mdf@xxxxxxxxxx>
> ---
>  drivers/net/ethernet/dec/tulip/de2104x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c
> index cb116b530f5e..2610efe4f873 100644
> --- a/drivers/net/ethernet/dec/tulip/de2104x.c
> +++ b/drivers/net/ethernet/dec/tulip/de2104x.c
> @@ -85,7 +85,7 @@ MODULE_PARM_DESC (rx_copybreak, "de2104x Breakpoint at which Rx packets are copi
>  #define DSL			CONFIG_DE2104X_DSL
>  #endif
>  
> -#define DE_RX_RING_SIZE		64
> +#define DE_RX_RING_SIZE		128
>  #define DE_TX_RING_SIZE		64
>  #define DE_RING_BYTES		\
>  		((sizeof(struct de_desc) * DE_RX_RING_SIZE) +	\
> -- 
> 2.28.0.526.ge36021eeef-goog
> 

Thanks,
Moritz