Re: [PATCH net-next + leds v2 6/7] net: phy: marvell: add support for LEDs controlled by Marvell PHYs

From: Pavel Machek
Date: Thu Sep 10 2020 - 17:49:55 EST

On Wed 2020-09-09 18:25:51, Marek Behún wrote:
> This patch adds support for controlling the LEDs connected to several
> families of Marvell PHYs via the PHY HW LED trigger API. These families
> are: 88E1112, 88E1121R, 88E1240, 88E1340S, 88E1510 and 88E1545. More can
> be added.
> This patch does not yet add support for compound LED modes. This could
> be achieved via the LED multicolor framework.
> Settings such as HW blink rate or pulse stretch duration are not yet
> supported.
> Signed-off-by: Marek Behún <marek.behun@xxxxxx>

I suggest limiting to "useful" hardware modes, and documenting what
those modes do somewhere.

Best regards,

(cesky, pictures)

Attachment: signature.asc
Description: PGP signature