Re: [PATCH v2] spi: spi-nxp-fspi: Add ACPI support

From: Mark Brown
Date: Fri Sep 11 2020 - 08:24:59 EST

On Fri, Sep 11, 2020 at 05:32:24PM +0530, Kuldip Dwivedi wrote:

> Here I can think two possible approaches
> 1. Changes in DT to use indexed based lookup

This is not going to be OK, it will break existing users relying on the
naming and makes the DTs less usable.

> 2. We Can check for ACPI fw node to distinguish between DT and ACPI like
> below..
> if (is_acpi_node(f->dev->fwnode))
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> else
> res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> "fspi_base");

Yes, this should be good.

Attachment: signature.asc
Description: PGP signature