AW: [PATCH 04/24] eventfd.2: Use 'PRIxN' macros when printing C99 fixed-width integer types

From: Walter Harms
Date: Fri Sep 11 2020 - 13:38:33 EST


I do not think that this is a good idea.
An example should be clear and easy to understand.
(e.g. with reduced error handling)

These C99 macros are over the top for me.

jm2c
wh
________________________________________
Von: linux-man-owner@xxxxxxxxxxxxxxx [linux-man-owner@xxxxxxxxxxxxxxx] im Auftrag von Alejandro Colomar [colomar.6.4.3@xxxxxxxxx]
Gesendet: Donnerstag, 10. September 2020 23:13
An: mtk.manpages@xxxxxxxxx
Cc: linux-man@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Alejandro Colomar
Betreff: [PATCH 04/24] eventfd.2: Use 'PRIxN' macros when printing C99 fixed-width integer types

Signed-off-by: Alejandro Colomar <colomar.6.4.3@xxxxxxxxx>
---
man2/eventfd.2 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/man2/eventfd.2 b/man2/eventfd.2
index 929234ab7..71e9d85b4 100644
--- a/man2/eventfd.2
+++ b/man2/eventfd.2
@@ -386,6 +386,7 @@ Parent read 28 (0x1c) from efd
.EX
#include <sys/eventfd.h>
#include <unistd.h>
+#include <inttypes.h> /* Definition of PRIu64 & PRIx64 */
#include <stdlib.h>
#include <stdio.h>
#include <stdint.h> /* Definition of uint64_t */
@@ -430,8 +431,7 @@ main(int argc, char *argv[])
s = read(efd, &u, sizeof(uint64_t));
if (s != sizeof(uint64_t))
handle_error("read");
- printf("Parent read %llu (0x%llx) from efd\en",
- (unsigned long long) u, (unsigned long long) u);
+ printf("Parent read %"PRIu64" (0x%"PRIx64") from efd\en", u, u);
exit(EXIT_SUCCESS);

case \-1:
--
2.28.0