Re: [PATCH net-next] net: dsa: b53: Configure VLANs while not filtering

[Florian Fainelli]

On 9/10/2020 9:19 PM, Florian Fainelli wrote:
> Update the B53 driver to support VLANs while not filtering. This
> requires us to enable VLAN globally within the switch upon driver
> initial configuration (dev->vlan_enabled).
>
> We also need to remove the code that dealt with PVID re-configuration in
> b53_vlan_filtering() since that function worked under the assumption
> that it would only be called to make a bridge VLAN filtering, or not
> filtering, and we would attempt to move the port's PVID accordingly.
>
> Now that VLANs are programmed all the time, even in the case of a
> non-VLAN filtering bridge, we would be programming a default_pvid for
> the bridged switch ports.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

David, Jakub, please hold off applying this just yet, Vladimir has 
submitted another patch for testing that would be IMHO a better way to 
deal with DSA switches that have an egress tagged default_pvid. 
Depending on the outcome of that patch, I will resubmit this one or 
request that you apply it.

Thanks
--
Florian