Re: [PATCH 0/3] xtensa: add seccomp support

From: Kees Cook
Date: Fri Sep 11 2020 - 15:38:54 EST


On Sat, Jul 18, 2020 at 07:16:51PM -0700, Max Filippov wrote:
> Hello,
>
> this series adds support for seccomp filter on xtensa and updates
> selftests/seccomp.

Hi!

Firstly, thanks for adding seccomp support! :) I would, however, ask
that you CC maintainers on these kinds of changes for feedback. I was
surprised to find the changes in the seccomp selftests today in Linus's
tree. I didn't seem to get CCed on this series, even though
get_maintainers shows this:

$ ./scripts/get_maintainer.pl 0001-selftests-seccomp-add-xtensa-support.mbox
Kees Cook <keescook@xxxxxxxxxxxx> (supporter:SECURE COMPUTING)
Andy Lutomirski <luto@xxxxxxxxxxxxxx> (reviewer:SECURE COMPUTING)
Will Drewry <wad@xxxxxxxxxxxx> (reviewer:SECURE COMPUTING)
Shuah Khan <shuah@xxxxxxxxxx> (maintainer:KERNEL SELFTEST FRAMEWORK)
...

Regardless, I'm still glad to have more arch support! :) I'll send a
follow-up patch to refactor a bit of the selftest.

Thanks,

--
Kees Cook