Re: [PATCH net-next] net/socket.c: Remove an unused header file <linux/if_frad.h>

From: David Miller
Date: Fri Sep 11 2020 - 17:41:25 EST


From: Xie He <xie.he.0141@xxxxxxxxx>
Date: Thu, 10 Sep 2020 23:07:20 -0700

> This header file is not actually used in this file. Let's remove it.

How did you test this assertion? As Jakub showed, the
dlci_ioctl_set() function needs to be declared because socket.c
references it.

All of your visual scanning of the code is wasted if you don't
do something simple like an "allmodconfig" or "allyesconfig"
build to test whether your change is correct or not.

Don't leave that step for us, that's your responsibility.