Re: [PATCH] ide/macide: Convert Mac IDE driver to platform driver

From: Finn Thain
Date: Fri Sep 11 2020 - 19:07:50 EST


On Fri, 11 Sep 2020, Geert Uytterhoeven wrote:

>
> Sorry, I completely missed that the Baboon case registers a
> "pata_platform" device instead of a "macide" device. Hence please
> ignore my comments related to that. Sorry for the noise.
>

No problem. That misunderstanding got me thinking about implications
stemming from my patch that I may have overlooked. Here's what I found.

1) Your presumption that the old macide driver would keep supporting all
variants does make sense, as that would delay disruption for as long as
possible (i.e. for as long as the IDE subsystem remains).

However, if my patch does not get merged until 2021, that disruption would
not arrive earlier than promised by commit 7ad19a99ad431 ("ide: officially
deprecated the legacy IDE driver").

2) My patch omitted a mac_defconfig update that would enable an
alternative driver for the Baboon case. I will remedy this in v2.

3) It turns out that the Debian/m68k kernel config has
CONFIG_BLK_DEV_PLATFORM=m. This will work fine with this patch. (I assume
that Debian developers will replace CONFIG_BLK_DEV_PLATFORM with
CONFIG_PATA_PLATFORM prior to the removal of the IDE subsystem next year.)