Re: [PATCH v2 08/14] habanalabs/gaudi: add a new IOCTL for NIC control operations

[Oded Gabbay]

On Sat, Sep 12, 2020 at 6:07 PM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
>
> Hi,
>
> On 9/12/20 7:41 AM, Oded Gabbay wrote:
> > +#define HL_IOCTL_NIC _IOWR('H', 0x07, struct hl_nic_args)
>
>
> ioctl numbers ('H') should be documented in
> Documentation/userspace-api/ioctl/ioctl-number.rst
>
> Sorry if I missed seeing that. (I scanned quickly.)
>
> thanks.
>
> --
> ~Randy
>

Hi Randy,
It is already documented for some time now:

'H'   00-0F  uapi/misc/habanalabs.h                                  conflict!

I think you commented on this a few releases ago and I added it then :)

Thanks,
Oded