Re: [PATCH v18 2/3] drivers: input:keyboard: Add mtk keypad driver

From: Dmitry Torokhov
Date: Mon Sep 14 2020 - 01:53:33 EST


Hi Fengping,

On Wed, Sep 09, 2020 at 03:22:00PM +0800, Fengping Yu wrote:
> From: "fengping.yu" <fengping.yu@xxxxxxxxxxxx>
>
> This patch adds matrix keypad support for Mediatek SoCs.

I am generally happy with the driver, however I do not believe this will
be the only Mediatek driver ever. Do you think we could rename it to
mt6779-keypad.c and use mt6779_keypad_ as prefix for function names?

Thanks!

--
Dmitry