Re: [PATCH v6 2/3] irqchip: Add Actions Semi Owl SIRQ controller

From: Cristian Ciocaltea
Date: Mon Sep 14 2020 - 03:02:43 EST


Hi Marc,

On Fri, Sep 11, 2020 at 05:22:41PM +0100, Marc Zyngier wrote:
> On 2020-09-08 09:20, Cristian Ciocaltea wrote:
> > This interrupt controller is found in the Actions Semi Owl SoCs (S500,
> > S700 and S900) and provides support for handling up to 3 external
> > interrupt lines.
> >
> > Each line can be independently configured as interrupt and triggers on
> > either of the edges or either of the levels. Additionally, each line
> > can also be masked individually.
> >
> > The patch is based on the work started by Parthiban Nallathambi:
> > https://lore.kernel.org/lkml/20181126100356.2840578-1-pn@xxxxxxx/
> >
> > Signed-off-by: Parthiban Nallathambi <pn@xxxxxxx>
> > Signed-off-by: Saravanan Sekar <sravanhome@xxxxxxxxx>
> > [cristi: optimized DT, various fixes/cleanups/improvements]
> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxx>
>
> Who is the author of these patches? If this is a co-development, please
> use the relevant tags. Otherwise, the author of the patch must come as
> the first SoB.

I took the authorship for the driver patch, as mentioned in the cover
letter. So, if I understand correctly, my SoB should be moved on top and
I assume I also need to drop the related comment line.

> The patch itself looks good.

Thanks for reviewing,
Cristi

>
> M.
> --
> Jazz is not dead. It just smells funny...