Re: [PATCH -next] extcon: axp288: use module_platform_driver to simplify the code

[Hans de Goede]

Hi,

On 9/14/20 8:54 AM, Liu Shixin wrote:
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@xxxxxxxxxx>

Thank you for the cleanup, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans


> ---
>   drivers/extcon/extcon-axp288.c | 13 +------------
>   1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
> index 525345367260..fdb31954cf2b 100644
> --- a/drivers/extcon/extcon-axp288.c
> +++ b/drivers/extcon/extcon-axp288.c
> @@ -491,18 +491,7 @@ static struct platform_driver axp288_extcon_driver = {
>   		.pm = &axp288_extcon_pm_ops,
>   	},
>   };
> -
> -static int __init axp288_extcon_init(void)
> -{
> -	return platform_driver_register(&axp288_extcon_driver);
> -}
> -module_init(axp288_extcon_init);
> -
> -static void __exit axp288_extcon_exit(void)
> -{
> -	platform_driver_unregister(&axp288_extcon_driver);
> -}
> -module_exit(axp288_extcon_exit);
> +module_platform_driver(axp288_extcon_driver);
>   
>   MODULE_AUTHOR("Ramakrishna Pallala <ramakrishna.pallala@xxxxxxxxx>");
>   MODULE_AUTHOR("Hans de Goede <hdegoede@xxxxxxxxxx>");