Re: [PATCH -next] pinctrl: sprd: use module_platform_driver to simplify the code

From: Chunyan Zhang
Date: Mon Sep 14 2020 - 04:13:49 EST


On Mon, 14 Sep 2020 at 14:32, Liu Shixin <liushixin2@xxxxxxxxxx> wrote:
>
> module_platform_driver() makes the code simpler by eliminating
> boilerplate code.
>
> Signed-off-by: Liu Shixin <liushixin2@xxxxxxxxxx>

Acked-by: Chunyan Zhang <zhang.lyra@xxxxxxxxx>

Thanks,
Chunyan

> ---
> drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c | 13 +------------
> 1 file changed, 1 insertion(+), 12 deletions(-)
>
> diff --git a/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c b/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> index 06c8671b40e7..d14f382f2392 100644
> --- a/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> +++ b/drivers/pinctrl/sprd/pinctrl-sprd-sc9860.c
> @@ -946,18 +946,7 @@ static struct platform_driver sprd_pinctrl_driver = {
> .remove = sprd_pinctrl_remove,
> .shutdown = sprd_pinctrl_shutdown,
> };
> -
> -static int sprd_pinctrl_init(void)
> -{
> - return platform_driver_register(&sprd_pinctrl_driver);
> -}
> -module_init(sprd_pinctrl_init);
> -
> -static void sprd_pinctrl_exit(void)
> -{
> - platform_driver_unregister(&sprd_pinctrl_driver);
> -}
> -module_exit(sprd_pinctrl_exit);
> +module_platform_driver(sprd_pinctrl_driver);
>
> MODULE_DESCRIPTION("SPREADTRUM Pin Controller Driver");
> MODULE_AUTHOR("Baolin Wang <baolin.wang@xxxxxxxxxxxxxx>");
> --
> 2.25.1
>