Re: [PATCH 3/3] ARM: dts: add SD5203 dts

[Leizhen (ThunderTown)]

On 2020/9/14 17:29, Wei Xu wrote:
> Hi Zhen,
> 
> On 2020/9/3 20:27, Zhen Lei wrote:
>> From: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
>>
>> Add sd5203.dts for Hisilicon SD5203 SoC platform.
>>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
>> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/Makefile   |  2 +
>>  arch/arm/boot/dts/sd5203.dts | 90 ++++++++++++++++++++++++++++++++++++
>>  2 files changed, 92 insertions(+)
>>  create mode 100644 arch/arm/boot/dts/sd5203.dts
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 4572db3fa5ae..1d1262df5c55 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -357,6 +357,8 @@ dtb-$(CONFIG_ARCH_MPS2) += \
>>  	mps2-an399.dtb
>>  dtb-$(CONFIG_ARCH_MOXART) += \
>>  	moxart-uc7112lx.dtb
>> +dtb-$(CONFIG_ARCH_SD5203) += \
>> +	sd5203.dtb
>>  dtb-$(CONFIG_SOC_IMX1) += \
>>  	imx1-ads.dtb \
>>  	imx1-apf9328.dtb
>> diff --git a/arch/arm/boot/dts/sd5203.dts b/arch/arm/boot/dts/sd5203.dts
>> new file mode 100644
>> index 000000000000..99da46072f72
>> --- /dev/null
>> +++ b/arch/arm/boot/dts/sd5203.dts
>> @@ -0,0 +1,90 @@
>> +// SPDX-License-Identifier: GPL-2.0-only
>> +/*
>> + * Copyright (c) 2020 Hisilicon Limited.
>> + *
>> + * DTS file for Hisilicon SD5203 Board
>> + */
>> +
>> +/dts-v1/;
>> +
>> +/ {
>> +	model = "Hisilicon SD5203";
>> +	compatible = "hisilicon,sd5203";
> 
> Can you please add the binding document as well?

OK, I will do it.

> 
>> +	interrupt-parent = <&vic>;
>> +	#address-cells = <1>;
>> +	#size-cells = <1>;
>> +
>> +	chosen {
>> +		bootargs="console=ttyS0,9600 earlycon=uart8250,mmio32,0x1600d000";
>> +	};
>> +
>> +	aliases {
>> +		serial0 = &uart0;
>> +	};
>> +
>> +	cpu {
>> +		compatible = "arm,arm926ej-s";
>> +		device_type = "cpu";
>> +	};
>> +
>> +	memory@30000000 {
>> +		device_type = "memory";
>> +		reg = <0x30000000 0x8000000>;
>> +	};
>> +
>> +	soc {
>> +		#address-cells = <1>;
>> +		#size-cells = <1>;
>> +		compatible = "simple-bus";
>> +		ranges;
>> +
>> +		vic: interrupt-controller@10130000 {
>> +			compatible = "hisilicon,sd5203-vic";

As Marc Zyngier's suggestion, I discarded adding an independent SD5203-VIC
driver, but make the dw-apb-ictl irqchip driver to support hierarchy irq domain.
I will send V4 of this irqchip driver today.

Here is the link of V3:
https://lkml.org/lkml/2020/9/9/94

> 
> Ditto.
> Thanks!
> 
> Best Regards,
> Wei
> 
>> +			reg = <0x10130000 0x1000>;
>> +			interrupt-controller;
>> +			#interrupt-cells = <1>;
>> +		};
>> +
>> +		refclk125mhz: refclk125mhz {
>> +			compatible = "fixed-clock";
>> +			#clock-cells = <0>;
>> +			clock-frequency = <125000000>;
>> +		};
>> +
>> +		timer0: timer@16002000 {
>> +			compatible = "arm,sp804", "arm,primecell";
>> +			reg = <0x16002000 0x1000>;
>> +			interrupts = <4>;
>> +			clocks = <&refclk125mhz>;
>> +			clock-names = "apb_pclk";
>> +		};
>> +
>> +		timer1: timer@16003000 {
>> +			compatible = "arm,sp804", "arm,primecell";
>> +			reg = <0x16003000 0x1000>;
>> +			interrupts = <5>;
>> +			clocks = <&refclk125mhz>;
>> +			clock-names = "apb_pclk";
>> +		};
>> +
>> +		uart0: serial@1600D000 {
>> +			compatible = "snps,dw-apb-uart";
>> +			reg = <0x1600D000 0x1000>;
>> +			bus_id = "uart0";
>> +			clocks = <&refclk125mhz>;
>> +			clock-names = "apb_pclk";
>> +			reg-shift = <2>;
>> +			interrupts = <17>;
>> +		};
>> +
>> +		uart1: serial@1600C000 {
>> +			compatible = "snps,dw-apb-uart";
>> +			reg = <0x1600C000 0x1000>;
>> +			clocks = <&refclk125mhz>;
>> +			clock-names = "apb_pclk";
>> +			reg-shift = <2>;
>> +			interrupts = <16>;
>> +			status = "disabled";
>> +		};
>> +	};
>> +};
>>
> 
> .
>