Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

From: Jakub Kicinski
Date: Mon Sep 14 2020 - 16:03:08 EST

Next message: Kees Cook: "Re: [REGRESSION] x86/entry: Tracer no longer has opportunity to change the syscall number at entry via orig_ax"
Previous message: Sean Christopherson: "[PATCH 2/2] KVM: VMX: Invoke NMI handler via indirect call instead of INTn"
In reply to: David Miller: "Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()"
Next in thread: Tariq Toukan: "Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote:
> 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the
> local variable declaration, not only its usage.

I was actually wondering about this when working on the pause stat
patch. Where is MLX4_EN_PERF_STAT ever defined?

$ git grep MLX4_EN_PERF_STAT
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#ifdef MLX4_EN_PERF_STAT
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h:#endif /* MLX4_EN_PERF_STAT */
drivers/net/ethernet/mellanox/mlx4/mlx4_stats.h:#ifdef MLX4_EN_PERF_STAT

Next message: Kees Cook: "Re: [REGRESSION] x86/entry: Tracer no longer has opportunity to change the syscall number at entry via orig_ax"
Previous message: Sean Christopherson: "[PATCH 2/2] KVM: VMX: Invoke NMI handler via indirect call instead of INTn"
In reply to: David Miller: "Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()"
Next in thread: Tariq Toukan: "Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]