Re: [PATCH net-next] net: pxa168_eth: remove unused variable 'retval' int pxa168_eth_change_mtu()

From: David Miller
Date: Mon Sep 14 2020 - 16:43:59 EST


From: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>
Date: Mon, 14 Sep 2020 21:19:12 +0800

> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning:
> variable 'retval' set but not used [-Wunused-but-set-variable]
> 1190 | int retval;
> | ^~~~~~
>
> Function pxa168_eth_change_mtu() always return zero, so variable 'retval'
> is redundant, just remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@xxxxxxxxxx>

Applied.