Re: [PATCH 1/3] fpga: dfl: move dfl_device_id to mod_devicetable.h

[Moritz Fischer]

Hao,

On Fri, Sep 11, 2020 at 06:50:18AM +0000, Wu, Hao wrote:
> > On 9/10/20 1:41 AM, Xu Yilun wrote:
> > > On Wed, Sep 09, 2020 at 05:55:33AM -0700, Tom Rix wrote:
> > >> On 9/7/20 10:48 PM, Xu Yilun wrote:
> > >>> In order to support MODULE_DEVICE_TABLE() for dfl device driver, this
> > >>> patch moves struct dfl_device_id to mod_devicetable.h
> > >>>
> > >>> Signed-off-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> > >>> Signed-off-by: Wu Hao <hao.wu@xxxxxxxxx>
> > >>> Signed-off-by: Matthew Gerlach <matthew.gerlach@xxxxxxxxxxxxxxx>
> > >>> Signed-off-by: Russ Weight <russell.h.weight@xxxxxxxxx>
> > >>> ---
> > >>>  drivers/fpga/dfl.h              | 13 +------------
> > >>>  include/linux/mod_devicetable.h | 12 ++++++++++++
> > >>>  2 files changed, 13 insertions(+), 12 deletions(-)
> > >>>
> > >>> diff --git a/drivers/fpga/dfl.h b/drivers/fpga/dfl.h
> > >>> index 5dc758f..d5b0760 100644
> > >>> --- a/drivers/fpga/dfl.h
> > >>> +++ b/drivers/fpga/dfl.h
> > >>> @@ -26,6 +26,7 @@
> > >>>  #include <linux/slab.h>
> > >>>  #include <linux/uuid.h>
> > >>>  #include <linux/fpga/fpga-region.h>
> > >>> +#include <linux/mod_devicetable.h>
> 
> Please fix the order for the new one, other places to good to me.
> Acked-by: Wu Hao <hao.wu@xxxxxxxxx>  for DFL related changes after this fix.

Do you mean the order of the includes, like alphabeticized? If it's
minor I can fix it up when applying.

Thanks,
Moritz