Re: [PATCH 06/13] dt-bindings: mfd: rohm,bd71837-pmic: Add common properties

From: Rob Herring
Date: Mon Sep 14 2020 - 18:44:18 EST


On Fri, Sep 04, 2020 at 04:53:05PM +0200, Krzysztof Kozlowski wrote:
> Add common properties appearing in DTSes (clock-names,
> clock-output-names) to fix dtbs_check warnings like:
>
> arch/arm64/boot/dts/freescale/imx8mq-librem5-r2.dt.yaml:
> pmic@4b: 'clock-names', 'clock-output-names', do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> ---
> .../devicetree/bindings/mfd/rohm,bd71837-pmic.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
> index 65018a019e1d..ecce0d5e3a95 100644
> --- a/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd71837-pmic.yaml
> @@ -32,9 +32,15 @@ properties:
> clocks:
> maxItems: 1
>
> + clock-names:
> + maxItems: 1

Needs to define what the name is.

> +
> "#clock-cells":
> const: 0
>
> + clock-output-names:
> + maxItems: 1

Ideally this one too, but we've been more flexible on it.

> +
> # The BD718x7 supports two different HW states as reset target states. States
> # are called as SNVS and READY. At READY state all the PMIC power outputs go
> # down and OTP is reload. At the SNVS state all other logic and external
> --
> 2.17.1
>