Re: [PATCH v3 0/6] tracing: export event trace and trace_marker

From: Tingwei Zhang
Date: Mon Sep 14 2020 - 19:25:33 EST


On Tue, Sep 15, 2020 at 06:43:09AM +0800, Steven Rostedt wrote:
> On Wed, 2 Sep 2020 07:28:39 +0800
> Tingwei Zhang <tingweiz@xxxxxxxxxxxxxx> wrote:
>
> > Hi Alexander,
> >
> > May I know your comments for this patch set?
>
> I ran your patch set against get_maintainers.pl and it came up with this:
>
> Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> (maintainer:SYSTEM
> TRACE MODULE CLASS)
> Maxime Coquelin <mcoquelin.stm32@xxxxxxxxx> (maintainer:ARM/STM32
> ARCHITECTURE)
> Alexandre Torgue <alexandre.torgue@xxxxxx> (maintainer:ARM/STM32
> ARCHITECTURE)
> Steven Rostedt <rostedt@xxxxxxxxxxx> (maintainer:TRACING)
> Ingo Molnar <mingo@xxxxxxxxxx> (maintainer:TRACING)
> linux-stm32@xxxxxxxxxxxxxxxxxxxxxxxxxxxx (moderated list:ARM/STM32
> ARCHITECTURE)
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx (moderated list:ARM/STM32
> ARCHITECTURE)
> linux-kernel@xxxxxxxxxxxxxxx (open list)
>
> I would use that to know who to send to.
>
> You have Alexander, myself, Ingo and LKML, but you should add the others
> in
> that list for this series, and then it may get noticed. Please use
> get_maintainers.pl for future patches if you don't know who to send them
> to.
>
> -- Steve
>
Thanks a lot for the detail instructions, Steve. I noticed that after
senting previous mail to Alexander.

I sent the patchset to maintainers and mail list as you mentioned in
https://patchwork.kernel.org/cover/11752107/.

Thanks,
Tingwei

> >
> > Thanks,
> > Tingwei
> >
> > On Thu, Aug 13, 2020 at 09:45:46AM +0800, Tingwei Zhang wrote:
> > > Ftrace has ability to export trace packets to other destination.
> > > Currently, only function trace can be exported. This series extends
> the
> > > support to event trace and trace_maker. STM is one possible
> destination to
> > > export ftrace. Use separate channel for each CPU to avoid mixing up
> > > packets
> > > from different CPUs together.
> > >
> > > Change from v2:
> > > Change flag definition to BIT(). (Steven)
> > > Add comment in stm_ftrace_write() to clarify it's safe to use
> > > smp_processor_id() here since preempt is disabled. (Steven)
> > >
> > > Change from v1:
> > > All changes are suggested by Steven Rostedt.
> > > User separate flag to control function trace, event trace and trace
> mark.
> > > Allocate channels according to num_possible_cpu() dynamically.
> > > Move ftrace_exports routines up so all ftrace can use them.
> > >
> > > Tingwei Zhang (6):
> > > stm class: ftrace: change dependency to TRACING
> > > tracing: add flag to control different traces
> > > tracing: add trace_export support for event trace
> > > tracing: add trace_export support for trace_marker
> > > stm class: ftrace: enable supported trace export flag
> > > stm class: ftrace: use different channel accroding to CPU
> > >
> > > drivers/hwtracing/stm/Kconfig | 2 +-
> > > drivers/hwtracing/stm/ftrace.c | 7 +-
> > > include/linux/trace.h | 7 +
> > > kernel/trace/trace.c | 270
> ++++++++++++++++++---------------
> > > 4 files changed, 159 insertions(+), 127 deletions(-)
> > >
> > > --
> > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
> Forum,
> > > a Linux Foundation Collaborative Project
> > >
>